Clean up lingering clusters after test runs#144
Merged
danielfrankcom merged 1 commit intomainfrom May 16, 2025
Merged
Conversation
danielfrankcom
force-pushed
the
feat/shared-cluster-cleanup
branch
2 times, most recently
from
f0250bb to
f71a91e
Compare
Contributor
|
Will this include a name parameter to filter clusters to delete? Or will it just be the repo tag? |
Contributor
Author
My intention is just the repo tag. We could add a name parameter if we wanted but I'm not sure it's necessary with the way the examples are defined at the moment. It would also be a bit complicated for Go since the name is dynamic and includes the workflow run ID or something. |
danielfrankcom
force-pushed
the
feat/shared-cluster-cleanup
branch
2 times, most recently
from
41cafe4 to
9827a9d
Compare
Contributor
Author
|
This is a successful run of the cleanup script which shows what it does when actually deleting things. I stacked the Rust account with various types and states of leftover clusters before this run to give the script something to do. |
danielfrankcom
force-pushed
the
feat/shared-cluster-cleanup
branch
4 times, most recently
from
12921af to
2e2bedd
Compare
trstephen-amazon
approved these changes
May 16, 2025
danielfrankcom
force-pushed
the
feat/shared-cluster-cleanup
branch
from
2e2bedd to
da6531e
Compare
mitchell-elholm
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #136
This change introduces a script to clean up lingering clusters. It only applies to clusters that are not already deleting, and which have the correct
Repotag. The script also exits early if theIS_CIflag isn't set for additional safety.The
clean-clusters.ymlworkflow can be called to clean up the clusters generated by other workflows.oThings needed before review:
Maybe add a sanity check for the minimum version to the script.This is a bit complicated in Bash so I won't bother for nowBy submitting this pull request, I confirm that my contribution is made under the terms of the MIT-0 license.